hansjone/dsh-im-ops
1
0
Fork 0
mirror of https://github.com/hansjone/dsh-im-ops.git synced 2026-10-10 23:10:46 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remember direct recipients for connection tests

Browse source
This commit is contained in:
xmanrui 2026-08-19 11:24:50 +08:00
parent fb61c4235f
commit 3ac70a7c65
34 changed files with 397 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

73
test/channels/shared/text-harness-bridge.test.mjs
View file

@ -2,6 +2,7 @@ import assert from 'node:assert/strict';
import test from 'node:test';
import { DiscordHarnessBridge } from '../../../src/channels/discord/discord-bridge.mjs';
import { connectionTestTarget } from '../../../src/channels/shared/connection-test.mjs';
import { TextHarnessBridge } from '../../../src/channels/shared/text-harness-bridge.mjs';
import { SlackHarnessBridge } from '../../../src/channels/slack/slack-bridge.mjs';
import { TelegramHarnessBridge } from '../../../src/channels/telegram/telegram-bridge.mjs';
@ -149,6 +150,78 @@ test('all four shared text channels execute /compact outside the model prompt pa
}
});
test('Slack, Telegram, and Discord remember any valid direct message per bot', async () => {
for (const [name, Bridge] of [
['slack', SlackHarnessBridge],
['telegram', TelegramHarnessBridge],
['discord', DiscordHarnessBridge],
]) {
let sessionSequence = 0;
const harness = {
createSession: async () => `${name}-session-${++sessionSequence}`,
ask: async () => `${name} reply`,
};
const first = stateFixture();
const second = stateFixture();
const firstSent = [];
const secondSent = [];
const firstBot = {
sendText: async (target, text) => firstSent.push({ target, text }),
};
const secondBot = {
sendText: async (target, text) => secondSent.push({ target, text }),
};
const firstBridge = new Bridge({ bot: firstBot, harness, state: first.state });
const secondBridge = new Bridge({ bot: secondBot, harness, state: second.state });
const firstTarget = { channelId: `${name}-private-a` };
const secondTarget = { channelId: `${name}-private-b` };
await firstBridge.accept(message(`${name}-direct-a`, 'hello', {
conversationId: `${name}-private-a`,
replyTarget: { ...firstTarget, replyToMessageId: 'reply-a' },
connectionTestTarget: firstTarget,
}));
assert.deepEqual(connectionTestTarget(first.state), firstTarget, name);
await firstBridge.accept(message(`${name}-group`, 'hello group', {
kind: 'group',
conversationId: `${name}-group`,
addressed: true,
replyTarget: { channelId: `${name}-group` },
connectionTestTarget: { channelId: `${name}-group` },
}));
assert.deepEqual(connectionTestTarget(first.state), firstTarget, `${name} group`);
await firstBridge.accept(message(`${name}-direct-a`, 'duplicate', {
conversationId: `${name}-private-replay`,
replyTarget: { channelId: `${name}-private-replay` },
connectionTestTarget: { channelId: `${name}-private-replay` },
}));
assert.deepEqual(connectionTestTarget(first.state), firstTarget, `${name} duplicate`);
await secondBridge.accept(message(`${name}-direct-b`, 'hello', {
conversationId: `${name}-private-b`,
replyTarget: { ...secondTarget, replyToMessageId: 'reply-b' },
connectionTestTarget: secondTarget,
}));
assert.deepEqual(connectionTestTarget(second.state), secondTarget, `${name} second bot`);
const reconnectedFirstBridge = new Bridge({ bot: firstBot, harness, state: first.state });
await reconnectedFirstBridge.sendConnectionTest(`${name} first test`);
await secondBridge.sendConnectionTest(`${name} second test`);
assert.deepEqual(
firstSent.find(({ text }) => text === `${name} first test`)?.target,
firstTarget,
`${name} reconnect`,
);
assert.deepEqual(
secondSent.find(({ text }) => text === `${name} second test`)?.target,
secondTarget,
`${name} bot isolation`,
);
}
});
test('answers a multi-question interaction on the fast lane with canonical values', async () => {
const fixture = stateFixture();
const sent = [];