fix: honor Harness default agent preset for IM sessions

This commit is contained in:
xmanrui 2026-08-19 03:26:02 +08:00
parent 26558e5e71
commit 8a64f2bc8c
15 changed files with 109 additions and 34 deletions

View file

@ -58,6 +58,7 @@ test('production assembly keeps secrets in credentials and creates per-bot runti
assert.equal(seen.controllerOptions.credentials, credentials);
assert.equal(seen.harnessOptions.baseUrl.href, 'http://127.0.0.1:3080/');
assert.equal(seen.harnessOptions.autostart, false);
assert.equal(Object.hasOwn(seen.harnessOptions, 'agentPreset'), false);
const runtime = await seen.controllerOptions.createRuntime({
botId: 'dt_abc',
config: { botId: 'dt_abc', clientId: 'dingabc' },
@ -71,4 +72,21 @@ test('production assembly keeps secrets in credentials and creates per-bot runti
assert.equal(seen.supervisorClosed, true);
assert.equal(seen.controllerClosed, true);
assert.equal(seen.harnessStopped, true);
const productionWithPreset = await createProductionController({
credentials,
webServer: { port: 3080 },
logger: () => console,
}, { dataDir: directory, agentPreset: 'router-standard' }, {
ConfigStore,
DeviceAuth,
StateStore,
HarnessClient: Harness,
Controller,
Runtime,
createConnectionSupervisor: () => supervisor,
});
assert.equal(seen.harnessOptions.agentPreset, 'router-standard');
await productionWithPreset.close();
});

View file

@ -45,6 +45,34 @@ test('all legacy channel clients now use the shared Harness RPC transport', asyn
}
});
test('HarnessClient lets the Host resolve an omitted agent preset and forwards an explicit override', async () => {
const createPayload = async (options = {}) => {
const client = new HarnessClient({
baseUrl: 'http://127.0.0.1:3080',
workspace: '/tmp/default-workspace',
...options,
});
let payload;
client.ensureRunning = async () => true;
client.workspaceId = async () => 'workspace-one';
client.rpc = async (method, value) => {
assert.equal(method, 'session.create');
payload = value;
return { sessionId: 'session-one' };
};
assert.equal(await client.createSession(), 'session-one');
return payload;
};
assert.deepEqual(await createPayload(), { workspaceId: 'workspace-one' });
assert.deepEqual(await createPayload({ agentPreset: 'router-standard' }), {
workspaceId: 'workspace-one',
agentPreset: 'router-standard',
});
assert.deepEqual(await createPayload({ agentPreset: null }), { workspaceId: 'workspace-one' });
});
test('HarnessClient lists only absolute workspace paths', async () => {
const client = new HarnessClient({
baseUrl: 'http://127.0.0.1:3080',

View file

@ -9,6 +9,17 @@ import {
} from '../src/channels/shared/harness-client.mjs';
import { createHarnessCommandExecutor } from '../plugin-src/host/harness-command-executor.mjs';
const PRODUCTION_FILES = [
'plugin-src/host/channels/feishu/production.mjs',
'plugin-src/host/channels/weixin/production.mjs',
'plugin-src/host/channels/dingtalk/production.mjs',
'plugin-src/host/channels/wecom/production.mjs',
'plugin-src/host/channels/qq/production.mjs',
'plugin-src/host/channels/slack/production.mjs',
'plugin-src/host/channels/shared/production.mjs',
'plugin-src/host/channels/whatsapp/production.mjs',
];
function state(sessionId = 'session-one') {
return { sessionFor: () => sessionId };
}
@ -142,17 +153,7 @@ test('Host command executor invokes the commands Typert endpoint with the Sessio
});
test('all nine production channels receive the Host command executor', async () => {
const productionFiles = [
'plugin-src/host/channels/feishu/production.mjs',
'plugin-src/host/channels/weixin/production.mjs',
'plugin-src/host/channels/dingtalk/production.mjs',
'plugin-src/host/channels/wecom/production.mjs',
'plugin-src/host/channels/qq/production.mjs',
'plugin-src/host/channels/slack/production.mjs',
'plugin-src/host/channels/shared/production.mjs',
'plugin-src/host/channels/whatsapp/production.mjs',
];
for (const path of productionFiles) {
for (const path of PRODUCTION_FILES) {
const source = await readFile(new URL(`../${path}`, import.meta.url), 'utf8');
assert.match(source, /createHarnessCommandExecutor\(ctx, internals\.commandExecutor\)/, path);
assert.match(source, /commandExecutor \? \{ commandExecutor \} : \{\}/, path);
@ -169,3 +170,27 @@ test('all nine production channels receive the Host command executor', async ()
assert.match(source, /'typertGateway'/, channel);
}
});
test('all nine production channels defer an omitted agent preset to the Harness Host', async () => {
for (const path of PRODUCTION_FILES) {
const source = await readFile(new URL(`../${path}`, import.meta.url), 'utf8');
assert.doesNotMatch(source, /agentPreset:\s*config\.agentPreset\s*\?\?\s*['"]standard['"]/, path);
assert.match(
source,
/\.\.\.\(config\.agentPreset == null \? \{\} : \{ agentPreset: config\.agentPreset \}\)/,
path,
);
}
for (const channel of ['telegram', 'discord']) {
const source = await readFile(
new URL(`../plugin-src/host/channels/${channel}/production.mjs`, import.meta.url),
'utf8',
);
assert.match(
source,
/createTokenProductionController\(ctx, config, internals,/,
`${channel} must delegate to the shared production assembly`,
);
}
});