hansjone/dsh-im-ops
1
0
Fork 0
mirror of https://github.com/hansjone/dsh-im-ops.git synced 2026-10-12 21:40:50 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: preserve session titles without context enhancement

Browse source
This commit is contained in:
xmanrui 2026-09-01 22:30:23 +08:00
parent e8c9817598
commit d044f1b0aa
17 changed files with 527 additions and 223 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/channels/shared/workspace-session.mjs
View file

@ -1,4 +1,5 @@
import { withSessionBindingLock } from './session-binding-lock.mjs';
import { initialSessionTitle } from './session-title.mjs';
export const WORKSPACE_SESSION_STALE = 'workspace-session-stale';
@ -6,7 +7,7 @@ function workspaceSession(harness, sessionId) {
if (typeof harness.workspaceSession === 'function') {
return harness.workspaceSession(sessionId);
}
return Object.freeze({
const session = {
sessionId,
sessionExists: (...args) => harness.sessionExists(sessionId, ...args),
models: (...args) => harness.getSessionModels(sessionId, ...args),
@ -16,7 +17,11 @@ function workspaceSession(harness, sessionId) {
stopActiveTurn: (...args) => harness.stopActiveTurn(sessionId, ...args),
steerActiveTurn: (...args) => harness.steerActiveTurn(sessionId, ...args),
ask: (...args) => harness.ask(sessionId, ...args),
});
};
if (typeof harness.renameSession === 'function') {
session.renameTitle = (...args) => harness.renameSession(sessionId, ...args);
}
return Object.freeze(session);
}
async function sessionExists(session, options) {
@ -42,10 +47,21 @@ export async function askInWorkspaceSession({
key,
text,
content,
contextEnhanced = false,
createOptions,
existsOptions,
askOptions,
}) {
const initialTitle = contextEnhanced
? initialSessionTitle({
text,
content,
files: typeof askOptions === 'object' ? askOptions?.files : undefined,
})
: null;
const renameSignal = createOptions?.signal
?? (typeof askOptions === 'object' ? askOptions?.signal : undefined);
const renameOptions = renameSignal ? { signal: renameSignal } : undefined;
while (true) {
try {
const binding = await withSessionBindingLock(state, key, async () => {
@ -55,6 +71,16 @@ export async function askInWorkspaceSession({
sessionId = await createSession(harness, createOptions);
if (await state.setSession(key, sessionId) === false) return null;
session = workspaceSession(harness, sessionId);
if (initialTitle && typeof session.renameTitle === 'function') {
try {
await session.renameTitle(initialTitle, renameOptions);
} catch (error) {
if (error?.code === WORKSPACE_SESSION_STALE || renameOptions?.signal?.aborted) {
throw error;
}
console.warn('[dsh-im] unable to set the initial Session title:', error?.message ?? error);
}
}
}
return { sessionId, session };
});