mirror of
https://github.com/hansjone/netx.git
synced 2026-10-10 13:50:44 +08:00
Update topology tool skill
This commit is contained in:
parent
37dd43923f
commit
99a262e348
4 changed files with 212 additions and 7 deletions
|
|
@ -184,6 +184,40 @@ def _score_key(c: dict[str, Any]) -> tuple:
|
|||
)
|
||||
|
||||
|
||||
def _rerank_by_total(
|
||||
scored: list[dict[str, Any]],
|
||||
nid: str,
|
||||
pos: dict[str, tuple[float, float]],
|
||||
names: dict[str, str],
|
||||
links: list[tuple[str, str]],
|
||||
adj: dict[str, set[str]],
|
||||
*,
|
||||
re_rank_n: int = 20,
|
||||
) -> list[dict[str, Any]]:
|
||||
"""Re-rank top candidates by crossing + edge_clearance (multi-objective).
|
||||
|
||||
A move may increase crossings but resolve several edge-clearance hits;
|
||||
ranking by ``crossings + edge_clearance_hits`` aligns with verdict.total.
|
||||
"""
|
||||
from netx_topology_mcp.layout_metrics import compute_edge_clearance
|
||||
|
||||
n = min(re_rank_n, len(scored))
|
||||
for c in scored[:n]:
|
||||
trial = dict(pos)
|
||||
trial[nid] = (float(c["x"]), float(c["y"]))
|
||||
ec = compute_edge_clearance(trial, links, names=names, top_n=1)
|
||||
c["edge_clearance_hits"] = int(ec.get("edge_clearance_hits") or 0)
|
||||
head = sorted(
|
||||
scored[:n],
|
||||
key=lambda c: (
|
||||
int(c["crossings"]["global"]) + int(c.get("edge_clearance_hits", 0)),
|
||||
int(c["crossings"]["incident"]),
|
||||
float(c.get("stretch") or 1.0),
|
||||
),
|
||||
)
|
||||
return head + scored[n:]
|
||||
|
||||
|
||||
def _diversify_top(
|
||||
ranked: list[dict[str, Any]],
|
||||
*,
|
||||
|
|
@ -286,6 +320,9 @@ def orbit_sweep_node(
|
|||
protect_rigid: bool | str = "off",
|
||||
frozen_ids: set[str] | None = None,
|
||||
top_k: int = 3,
|
||||
y_min: float | None = None,
|
||||
y_max: float | None = None,
|
||||
objective: str = "crossing",
|
||||
) -> dict[str, Any]:
|
||||
"""Sweep polar candidates for one node; return diversified top-k.
|
||||
|
||||
|
|
@ -370,6 +407,15 @@ def orbit_sweep_node(
|
|||
if len(uniq) >= cand_cap:
|
||||
break
|
||||
|
||||
# Layered y constraint: skip candidates outside [y_min, y_max]
|
||||
if y_min is not None or y_max is not None:
|
||||
uniq = [
|
||||
(sx, sy, r, ang)
|
||||
for sx, sy, r, ang in uniq
|
||||
if (y_min is None or sy >= y_min)
|
||||
and (y_max is None or sy <= y_max)
|
||||
]
|
||||
|
||||
scored: list[dict[str, Any]] = []
|
||||
for sx, sy, r, ang in uniq:
|
||||
c = _eval_candidate(
|
||||
|
|
@ -417,6 +463,8 @@ def orbit_sweep_node(
|
|||
break
|
||||
|
||||
for sx, sy, r, ang in fine:
|
||||
if (y_min is not None and sy < y_min) or (y_max is not None and sy > y_max):
|
||||
continue
|
||||
key = (int(round(sx)), int(round(sy)))
|
||||
if key in seen:
|
||||
continue
|
||||
|
|
@ -440,6 +488,9 @@ def orbit_sweep_node(
|
|||
scored.append(c)
|
||||
|
||||
scored.sort(key=_score_key)
|
||||
# Multi-objective re-rank: optimize total score, not just crossings
|
||||
if objective == "total" and len(scored) > 1:
|
||||
scored = _rerank_by_total(scored, nid, pos, names, links, adj)
|
||||
# Prefer improving moves; still return best even if none improve.
|
||||
improving = [c for c in scored if c["delta"]["global"] < 0]
|
||||
pool = improving if improving else scored
|
||||
|
|
@ -458,9 +509,16 @@ def orbit_sweep_node(
|
|||
"improving_n": len(improving),
|
||||
"max_jump": jump,
|
||||
"angle_step": angle_step,
|
||||
"objective": objective,
|
||||
"y_band": (
|
||||
None if (y_min is None and y_max is None)
|
||||
else [y_min, y_max]
|
||||
),
|
||||
"hint": (
|
||||
"prefer rank1 unless util/label concern; then pick 2/3. "
|
||||
"apply with params.pick=1|2|3 or updateTopologyViewPositions."
|
||||
+ (" objective=total: rank by crossing+edge_clearance, may trade crossings for clearance."
|
||||
if objective == "total" else "")
|
||||
),
|
||||
}
|
||||
|
||||
|
|
@ -736,6 +794,16 @@ def orbit_params_from_overrides(overrides: dict[str, Any] | None) -> dict[str, A
|
|||
raw_p = o.get("portal_ids")
|
||||
if isinstance(raw_p, list):
|
||||
out["frozen_ids"] = {str(x) for x in raw_p if str(x)}
|
||||
# Layered y constraint (y_min/y_max): keep node within its layer band
|
||||
for yk in ("y_min", "y_max"):
|
||||
if o.get(yk) is not None:
|
||||
try:
|
||||
out[yk] = float(o[yk])
|
||||
except (TypeError, ValueError):
|
||||
pass
|
||||
# Multi-objective ranking: "crossing" (default) or "total"
|
||||
obj = str(o.get("objective") or "crossing").strip().lower()
|
||||
out["objective"] = "total" if obj in ("total", "score", "multi") else "crossing"
|
||||
return out
|
||||
|
||||
|
||||
|
|
|
|||
|
|
@ -131,6 +131,52 @@ def list_crossings(
|
|||
top_e = top_crossing_edges(
|
||||
pos_xy, links, names=names, top_n=5, edge_participation=edge_hit
|
||||
)
|
||||
# Fallback: when no drag_candidates (all hot nodes are high-degree hubs),
|
||||
# suggest from edge_clearance.top and crossing top_nodes regardless of degree.
|
||||
if not candidates:
|
||||
from netx_topology_mcp.layout_metrics import compute_edge_clearance
|
||||
|
||||
ec = compute_edge_clearance(pos_xy, links, names=names, top_n=5)
|
||||
for eh in (ec.get("top_edge_hits") or [])[:5]:
|
||||
nid = str(eh.get("fabric_node_id") or "")
|
||||
if not nid or nid not in pos:
|
||||
continue
|
||||
x, y, name = pos[nid]
|
||||
deg = len(adj.get(nid, ()))
|
||||
candidates.append({
|
||||
"fabric_node_id": nid,
|
||||
"name": name,
|
||||
"short": _short_name(name),
|
||||
"x": round(x, 1),
|
||||
"y": round(y, 1),
|
||||
"degree": deg,
|
||||
"in_crossings": hit.get(nid, 0),
|
||||
"score": 0.0,
|
||||
"suggest_xy": [],
|
||||
"delta_crossings_est": 0,
|
||||
"reason": "edge_clearance_hit",
|
||||
})
|
||||
for tn in top5:
|
||||
nid = str(tn.get("fabric_node_id") or "")
|
||||
if not nid or nid not in pos:
|
||||
continue
|
||||
if any(c["fabric_node_id"] == nid for c in candidates):
|
||||
continue
|
||||
x, y, name = pos[nid]
|
||||
deg = len(adj.get(nid, ()))
|
||||
candidates.append({
|
||||
"fabric_node_id": nid,
|
||||
"name": name,
|
||||
"short": _short_name(name),
|
||||
"x": round(x, 1),
|
||||
"y": round(y, 1),
|
||||
"degree": deg,
|
||||
"in_crossings": tn.get("crossing_hits", 0),
|
||||
"score": round(tn.get("crossing_hits", 0) / max(deg, 1), 3),
|
||||
"suggest_xy": [],
|
||||
"delta_crossings_est": 0,
|
||||
"reason": "top_crossing_high_degree",
|
||||
})
|
||||
return {
|
||||
"edge_crossings": total_cross,
|
||||
"crossings_listed": len(crosses),
|
||||
|
|
|
|||
|
|
@ -512,6 +512,9 @@ def run_layout_on_graph(
|
|||
protect_rigid=protect,
|
||||
frozen_ids=frozen,
|
||||
top_k=int(knobs.get("top_k") or 3),
|
||||
y_min=knobs.get("y_min"),
|
||||
y_max=knobs.get("y_max"),
|
||||
objective=knobs.get("objective", "crossing"),
|
||||
)
|
||||
if not sweep.get("ok"):
|
||||
fin = score_state(st0)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue