Point VRF BGP neighbor aux at config_bgp_peer (running-config bgp).

Discover and aux both use zte.config_bgp_peer; enrich remote_as/activate/route-maps from intent. Guard with tests so aux templates cannot introduce extra placeholders.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
oliver 2026-09-22 11:56:01 +08:00
parent 089c88d35e
commit c14d4e81ff
3 changed files with 120 additions and 31 deletions

View file

@ -5,9 +5,15 @@ from __future__ import annotations
import unittest
from netx_api.biz_state.command_match import expand_from_bindings, match_command, preview_task_item
from netx_api.biz_state.profiles import all_profiles, get_profile, profiles_for_vendor
from netx_api.biz_state.profiles import (
all_profiles,
get_profile,
profile_to_public_dict,
profiles_for_vendor,
)
from netx_api.biz_state.parsers import normalize_lldp_neighbors
from netx_api.lldp_shared import parse_neighbor_output
import re
class BizStateProfileTests(unittest.TestCase):
@ -58,6 +64,47 @@ class BizStateProfileTests(unittest.TestCase):
hits = parse_neighbor_output("", vendor="zte", device_type="zte_zxros")
self.assertEqual(hits, [])
def test_vrf_neighbor_discover_and_aux_both_config_bgp(self) -> None:
for pid in (
"zte.bgp_vpnv4_vrf_neighbor_in",
"zte.bgp_vpnv4_vrf_neighbor_out",
"zte.bgp_vpnv6_vrf_neighbor_in",
"zte.bgp_vpnv6_vrf_neighbor_out",
):
p = get_profile(pid)
assert p is not None
for ph in p.placeholders:
self.assertEqual(ph.discover_profile_id, "zte.config_bgp_peer")
self.assertEqual([a.profile_id for a in p.aux_commands], ["zte.config_bgp_peer"])
pub = profile_to_public_dict(p)
aux = pub.get("aux_commands") or []
self.assertEqual(len(aux), 1)
self.assertIn("running-config bgp", aux[0]["command_template"])
def test_aux_templates_placeholders_subset_of_primary(self) -> None:
"""Aux CLI must not introduce placeholders outside primary params.
Prevents cases like VRF neighbor aux pointing at summary with <vrf>
while the UI shows both as if they were independent unbound vars.
"""
ph_re = re.compile(r"<([^>]+)>")
for p in all_profiles():
if not p.enabled or p.kind != "collect":
continue
primary_ph = {ph.name for ph in (p.placeholders or [])}
for a in p.aux_commands or []:
ap = get_profile(a.profile_id)
if ap is None:
continue
tmpl = str(ap.command_template or "")
aux_ph = set(ph_re.findall(tmpl))
extra = aux_ph - primary_ph
self.assertFalse(
extra,
f"{p.profile_id} aux {a.key} ({a.profile_id}) has "
f"placeholders {extra} not in primary {primary_ph}",
)
if __name__ == "__main__":
unittest.main()