From c92879daf35466ef18ffcbcad9d99a7385112b61 Mon Sep 17 00:00:00 2001
From: oliver <zhoutianjun127@126.com>
Date: Sun, 2 Aug 2026 19:10:49 +0800
Subject: [PATCH] Stop prompting SSH credentials for Telnet WebCRT sessions.

Telnet should authenticate interactively in the terminal; only managed/quick-connect SSH without a saved password opens the credential dialog.

Co-authored-by: Cursor <cursoragent@cursor.com>
---
 web/src/pages/WebcrtPage.tsx | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/web/src/pages/WebcrtPage.tsx b/web/src/pages/WebcrtPage.tsx
index 343e1a9..89dda07 100644
--- a/web/src/pages/WebcrtPage.tsx
+++ b/web/src/pages/WebcrtPage.tsx
@@ -347,10 +347,11 @@ function isSshAuthFailure(err: unknown): boolean {
   );
 }
 
-/** Inventory managed / Quick Connect. UME uses shared CLI profile — no per-NE popup. */
-function isInventoryTarget(target: Pick<CliTargetItem, "source" | "protocol">): boolean {
+/** Inventory SSH (managed / Quick Connect). Telnet authenticates in-terminal; UME uses shared profile. */
+function isInventorySsh(target: Pick<CliTargetItem, "source" | "protocol">): boolean {
   const src = String(target.source || "").toLowerCase();
-  return src === "webcrt" || src === "managed";
+  if (src !== "webcrt" && src !== "managed") return false;
+  return String(target.protocol || "ssh").toLowerCase() !== "telnet";
 }
 
 function isSessionGoneError(err: unknown): boolean {
@@ -941,8 +942,9 @@ export function WebcrtPage() {
       }
       if (connectingKeysRef.current.has(key)) return;
 
-      // Managed / WebCRT without saved password → credential popup (UME uses shared profile).
-      if (isInventoryTarget(target) && !target.has_password && !opts?.force) {
+      // Managed / WebCRT SSH without saved password → credential popup.
+      // Telnet stays interactive in the terminal (SecureCRT-style); UME uses shared profile.
+      if (isInventorySsh(target) && !target.has_password && !opts?.force) {
         openAuthForTarget(target);
         return;
       }
@@ -1016,7 +1018,7 @@ export function WebcrtPage() {
       } catch (err) {
         const message = webcrtErrorMessage(err, t);
         const needAuth =
-          isInventoryTarget(target) &&
+          isInventorySsh(target) &&
           (String(err).includes("credentials_incomplete") ||
             String(err).includes("connect_failed") ||
             isSshAuthFailure(err));
@@ -2450,7 +2452,7 @@ export function WebcrtPage() {
                             if (sid) {
                               void closeWebcrtSession(sid).catch(() => undefined);
                             }
-                            if (isInventoryTarget(tab.target) && isSshAuthFailure(errMsg)) {
+                            if (isInventorySsh(tab.target) && isSshAuthFailure(errMsg)) {
                               openAuthForTarget(tab.target, webcrtErrorMessage(errMsg, t));
                             }
                           } else if (state === "closed") {