hansjone/netx
1
0
Fork 0
mirror of https://github.com/hansjone/netx.git synced 2026-10-09 04:20:45 +08:00
Code Issues Projects Releases 1 Packages Wiki Activity Actions 2

Rename shared bgp_peer workbook sheet to BGP Status Summary.

Browse source 
Batch sheets are keyed by metric_id, so all AF summaries land in one tab; stop inheriting the first profile title (VPNv4).

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
oliver 2026-09-22 14:50:28 +08:00
parent c20a731f72
commit e89427297d
2 changed files with 89 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

65
tests/test_batch_workbook_api.py
View file

@ -70,6 +70,71 @@ class BatchWorkbookApiTests(unittest.TestCase):
self.assertEqual(out["sheets"][0]["commands"][0]["raw_command"], "show arp | one-line")
self.assertTrue(out["sheets"][0].get("title"))
def test_bgp_peer_sheet_uses_status_summary_title(self) -> None:
"""Shared metric_id bgp_peer must not inherit first AF profile title."""
batch = BizStateBatch(
id="b1",
task_id="t1",
status="ok",
command_count=2,
row_count=3,
)
cmds = [
BizStateBatchCommand(
id="c1",
batch_id="b1",
profile_id="zte.bgp_vpnv4_summary",
parser_id="bgp_peer",
metric_id="bgp_peer",
raw_command="show bgp vpnv4 unicast summary | one-line",
parse_status="ok",
row_count=2,
),
BizStateBatchCommand(
id="c2",
batch_id="b1",
profile_id="zte.bgp_ipv4_summary",
parser_id="bgp_peer",
metric_id="bgp_peer",
raw_command="show bgp ipv4 unicast summary | one-line",
parse_status="ok",
row_count=1,
),
]
db = MagicMock()
db.get.side_effect = lambda model, pk: batch if pk == "b1" else None
cmd_q = MagicMock()
cmd_q.filter.return_value.order_by.return_value.all.return_value = cmds
metric_count_q = MagicMock()
metric_count_q.filter.return_value.group_by.return_value.all.return_value = [
("bgp_peer", 3)
]
lldp_count_q = MagicMock()
lldp_count_q.filter.return_value.scalar.return_value = 0
def query(*_args, **_kwargs):
n = query.n
query.n += 1
if n == 0:
return cmd_q
if n == 1:
return metric_count_q
return lldp_count_q
query.n = 0
db.query.side_effect = query
with patch(
"netx_api.biz_state.service.batch_protect_info",
return_value={"protected": False, "reasons": []},
):
out = get_batch(db, "b1")
bgp = next(s for s in out["sheets"] if s["metric_id"] == "bgp_peer")
self.assertEqual(bgp["title"], "BGP Status Summary")
self.assertEqual(bgp["row_count"], 3)
self.assertEqual(len(bgp["commands"]), 2)
def test_list_metric_rows_rejects_commands_sheet(self) -> None:
db = MagicMock()
db.get.return_value = BizStateBatch(id="b1", task_id="t1")