mirror of
https://github.com/hansjone/netx.git
synced 2026-10-09 06:40:45 +08:00
oliver
e7f97b7cf6
Add fabric link browsing, conservative job retention, hour-based intervals, multi-worker start locking, and trim canvas discover UI in favor of the LLDP page. Co-authored-by: Cursor <cursoragent@cursor.com>
247 lines
8.3 KiB
Python
247 lines
8.3 KiB
Python
"""LLDP collect policy / dashboard (network topology management)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import unittest
|
|
from datetime import datetime, timedelta
|
|
from uuid import uuid4
|
|
|
|
from netx_api.db import Base, SessionLocal, engine
|
|
from netx_api.lldp_collect_schemas import LldpCollectPolicyUpdate
|
|
from netx_api.lldp_collect_service import (
|
|
build_discover_request,
|
|
ensure_policy,
|
|
get_dashboard,
|
|
has_running_job,
|
|
next_due_at,
|
|
update_policy,
|
|
)
|
|
from netx_api.models import LldpCollectPolicy, ManagedNE, TopoDiscoverJob, TopoDiscoverJobItem
|
|
from netx_api.topology_service import prune_discover_jobs, reclaim_stale_discover_jobs
|
|
|
|
|
|
class LldpCollectTests(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls) -> None:
|
|
Base.metadata.create_all(bind=engine)
|
|
from netx_api.topology_migrate import ensure_topology_schema
|
|
|
|
with engine.begin() as conn:
|
|
ensure_topology_schema(conn)
|
|
|
|
def setUp(self) -> None:
|
|
self.db = SessionLocal()
|
|
self.db.query(TopoDiscoverJobItem).delete()
|
|
self.db.query(TopoDiscoverJob).delete()
|
|
self.db.query(LldpCollectPolicy).delete()
|
|
self.db.commit()
|
|
|
|
def tearDown(self) -> None:
|
|
# Do not leave scheduled collect enabled in shared DB.
|
|
row = self.db.get(LldpCollectPolicy, 1)
|
|
if row is not None:
|
|
row.enabled = False
|
|
self.db.commit()
|
|
self.db.close()
|
|
|
|
def test_policy_defaults_disabled(self) -> None:
|
|
row = ensure_policy(self.db)
|
|
self.assertEqual(row.id, 1)
|
|
self.assertFalse(row.enabled)
|
|
dash = get_dashboard(self.db)
|
|
self.assertFalse(dash.policy.enabled)
|
|
self.assertIsNone(dash.next_due_at)
|
|
self.assertEqual(dash.policy.history_keep, 30)
|
|
|
|
def test_policy_enable_updates(self) -> None:
|
|
ensure_policy(self.db)
|
|
out = update_policy(
|
|
self.db,
|
|
LldpCollectPolicyUpdate(
|
|
enabled=True,
|
|
interval_hours=48,
|
|
concurrency=6,
|
|
scope_mode="all",
|
|
auto_add_unmatched=True,
|
|
history_keep=5,
|
|
),
|
|
)
|
|
self.assertTrue(out.enabled)
|
|
self.assertEqual(out.interval_hours, 48)
|
|
self.assertEqual(out.interval_days, 2)
|
|
self.assertEqual(out.concurrency, 6)
|
|
self.assertEqual(out.history_keep, 5)
|
|
due = next_due_at(self.db, ensure_policy(self.db))
|
|
self.assertIsNotNone(due)
|
|
|
|
def test_next_due_uses_hours_and_ignores_manual(self) -> None:
|
|
policy = ensure_policy(self.db)
|
|
policy.enabled = True
|
|
policy.interval_hours = 6
|
|
policy.interval_days = 1
|
|
self.db.commit()
|
|
now = datetime.utcnow()
|
|
sched = TopoDiscoverJob(
|
|
id=uuid4().hex,
|
|
scope="all_inventory",
|
|
trigger_mode="schedule",
|
|
status="done",
|
|
ended_at=now - timedelta(hours=1),
|
|
created_at=now - timedelta(hours=2),
|
|
updated_at=now - timedelta(hours=1),
|
|
)
|
|
manual = TopoDiscoverJob(
|
|
id=uuid4().hex,
|
|
scope="all_inventory",
|
|
trigger_mode="manual",
|
|
status="done",
|
|
ended_at=now,
|
|
created_at=now,
|
|
updated_at=now,
|
|
)
|
|
self.db.add(sched)
|
|
self.db.add(manual)
|
|
self.db.commit()
|
|
due = next_due_at(self.db, ensure_policy(self.db))
|
|
self.assertIsNotNone(due)
|
|
assert due is not None
|
|
self.assertEqual(due, sched.ended_at + timedelta(hours=6))
|
|
|
|
def test_start_discover_rejects_second_while_running(self) -> None:
|
|
from netx_api.topology_schemas import FabricDiscoverRequest
|
|
from netx_api.topology_service import start_discover_job
|
|
|
|
now = datetime.utcnow()
|
|
running = TopoDiscoverJob(
|
|
id=uuid4().hex,
|
|
scope="all_inventory",
|
|
trigger_mode="manual",
|
|
status="running",
|
|
created_at=now,
|
|
updated_at=now,
|
|
started_at=now,
|
|
)
|
|
self.db.add(running)
|
|
ensure_policy(self.db)
|
|
self.db.commit()
|
|
with self.assertRaises(Exception) as ctx:
|
|
start_discover_job(self.db, FabricDiscoverRequest(scope="ne_ids", ne_ids=["x"]))
|
|
detail = getattr(ctx.exception, "detail", str(ctx.exception))
|
|
self.assertEqual(detail, "lldp_collect_already_running")
|
|
|
|
def test_build_request_respects_source(self) -> None:
|
|
suffix = uuid4().hex[:8]
|
|
ne = ManagedNE(
|
|
id=f"m-{suffix}",
|
|
name=f"M-{suffix}",
|
|
ip_address=f"203.0.113.{(int(suffix[:2], 16) % 200) + 1}",
|
|
vendor="Cisco",
|
|
device_type="cisco_ios",
|
|
)
|
|
self.db.add(ne)
|
|
policy = ensure_policy(self.db)
|
|
policy.scope_mode = "selected"
|
|
# Same id string marked as ume should NOT resolve via managed path when building lists.
|
|
policy.selected_targets = [
|
|
{"source": "managed", "id": ne.id},
|
|
{"source": "ume", "id": f"ume-{suffix}"},
|
|
]
|
|
self.db.commit()
|
|
req = build_discover_request(ensure_policy(self.db))
|
|
self.assertEqual(req.managed_ne_ids, [ne.id])
|
|
self.assertEqual(req.ume_ne_ids, [f"ume-{suffix}"])
|
|
self.assertEqual(req.ne_ids, [])
|
|
self.db.delete(ne)
|
|
self.db.commit()
|
|
|
|
def test_prune_discover_jobs_keeps_newest(self) -> None:
|
|
now = datetime.utcnow()
|
|
ids: list[str] = []
|
|
for i in range(5):
|
|
jid = uuid4().hex
|
|
ids.append(jid)
|
|
self.db.add(
|
|
TopoDiscoverJob(
|
|
id=jid,
|
|
scope="all_inventory",
|
|
trigger_mode="manual",
|
|
status="done",
|
|
created_at=now - timedelta(minutes=5 - i),
|
|
updated_at=now - timedelta(minutes=5 - i),
|
|
ended_at=now - timedelta(minutes=5 - i),
|
|
)
|
|
)
|
|
self.db.add(
|
|
TopoDiscoverJobItem(
|
|
id=uuid4().hex,
|
|
job_id=jid,
|
|
ne_name=f"n{i}",
|
|
raw_preview="x" * 20,
|
|
created_at=now,
|
|
)
|
|
)
|
|
# Keep one open job — must survive prune.
|
|
open_id = uuid4().hex
|
|
self.db.add(
|
|
TopoDiscoverJob(
|
|
id=open_id,
|
|
scope="all_inventory",
|
|
trigger_mode="manual",
|
|
status="running",
|
|
created_at=now,
|
|
updated_at=now,
|
|
)
|
|
)
|
|
self.db.commit()
|
|
dropped = prune_discover_jobs(self.db, keep=2)
|
|
self.assertEqual(dropped, 3)
|
|
left = {r.id for r in self.db.query(TopoDiscoverJob).all()}
|
|
self.assertIn(open_id, left)
|
|
self.assertEqual(len(left), 3) # 2 finished + 1 running
|
|
|
|
def test_reclaim_force_all_open_on_startup(self) -> None:
|
|
now = datetime.utcnow()
|
|
job = TopoDiscoverJob(
|
|
id=uuid4().hex,
|
|
scope="all_inventory",
|
|
trigger_mode="schedule",
|
|
status="running",
|
|
total=10,
|
|
done=1,
|
|
created_at=now,
|
|
updated_at=now,
|
|
started_at=now,
|
|
)
|
|
self.db.add(job)
|
|
self.db.commit()
|
|
closed = reclaim_stale_discover_jobs(self.db, force_all_open=True)
|
|
self.assertEqual(closed, 1)
|
|
self.db.refresh(job)
|
|
self.assertEqual(job.status, "failed")
|
|
self.assertIn("stale_running_reset_on_startup", job.error or "")
|
|
self.assertIsNone(has_running_job(self.db))
|
|
|
|
def test_reclaim_running_by_stale_updated_at(self) -> None:
|
|
old = datetime.utcnow() - timedelta(hours=5)
|
|
job = TopoDiscoverJob(
|
|
id=uuid4().hex,
|
|
scope="ne_ids",
|
|
trigger_mode="manual",
|
|
status="running",
|
|
total=3,
|
|
done=0,
|
|
created_at=old,
|
|
updated_at=old,
|
|
started_at=old,
|
|
)
|
|
self.db.add(job)
|
|
self.db.commit()
|
|
closed = reclaim_stale_discover_jobs(self.db)
|
|
self.assertEqual(closed, 1)
|
|
self.db.refresh(job)
|
|
self.assertEqual(job.status, "failed")
|
|
self.assertIn("running_stale_timeout", job.error or "")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|