hansjone/oclaw
1
0
Fork 0
mirror of https://github.com/hansjone/oclaw.git synced 2026-10-08 23:33:16 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove dead confirm-strategy setting from chat UI.

Browse source 
Plan-mode confirm gate is gone; drop the settings control and coerce API values to strict.
This commit is contained in:
oliver 2026-08-11 02:42:32 +08:00
parent c901655848
commit 4277ad6b14
4 changed files with 14 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/test_admin_chat_stream_async_task.py
View file

@ -242,7 +242,7 @@ class AdminChatStreamAsyncTaskTests(unittest.TestCase):
# Session POST ignores interaction/specialist; user menu still has generalist.
self.assertEqual(str(body1.get("specialist") or ""), "generalist")
self.assertEqual(str(body1.get("memory_mode") or ""), "store_only")
self.assertEqual(str(body1.get("confirm_strategy") or ""), "auto")
self.assertEqual(str(body1.get("confirm_strategy") or ""), "strict")
resp2 = self.client.get(
f"/admin/api/chat/sessions/{self.session_id}/mode",
@ -254,7 +254,7 @@ class AdminChatStreamAsyncTaskTests(unittest.TestCase):
self.assertEqual(str(body2.get("interaction_mode") or ""), "expert")
self.assertEqual(str(body2.get("specialist") or ""), "generalist")
self.assertEqual(str(body2.get("memory_mode") or ""), "store_only")
self.assertEqual(str(body2.get("confirm_strategy") or ""), "auto")
self.assertEqual(str(body2.get("confirm_strategy") or ""), "strict")
def test_messages_use_session_mode_when_payload_omits_mode(self) -> None:
token = self._login()

10
tests/test_chat_mode_execution_persistence.py
View file

@ -44,8 +44,8 @@ def test_mode_session_and_user_prefs_merge_for_gateway() -> None:
assert specialist == "generalist"
assert memory_mode == "default"
assert execution_mode == "plan"
assert confirm_strategy == "auto"
assert plan_agent_version == "v2"
assert confirm_strategy == "strict"
assert plan_agent_version == "v1"
def test_mode_session_defaults_when_session_keys_missing() -> None:
@ -72,11 +72,13 @@ def test_invalid_execution_mode_on_session_dialog_falls_back_to_agent() -> None:
assert interaction_mode == "expert"
def test_invalid_confirm_strategy_on_user_menu_falls_back_to_strict() -> None:
def test_legacy_confirm_and_plan_agent_prefs_coerce_to_defaults() -> None:
store = _DummyStore()
store.set_setting("chat.user.mode.t1.u1.confirm_strategy", "invalid")
store.set_setting("chat.user.mode.t1.u1.confirm_strategy", "auto")
store.set_setting("chat.user.mode.t1.u1.plan_agent_version", "v2")
interaction_mode, specialist, memory_mode, execution_mode, confirm_strategy, plan_agent_version = (
_resolve_mode_settings(store=store, tenant_id="t1", user_id="u1", session_id="s1")
)
assert confirm_strategy == "strict"
assert plan_agent_version == "v1"
assert specialist == "generalist"