mirror of
https://github.com/hansjone/oclaw.git
synced 2026-10-13 03:30:46 +08:00
oliver
08a5520791
The QR poll showed a generic "network error" for any failure, and the server collapsed every upstream failure into an opaque 502 with no log. - Classify upstream failures (DNS, timeout, unreachable, TLS cert, HTTP status, bad response) and return host-specific localized messages. - Report why the post-scan user lookup failed instead of a generic invalid-credentials error. - Log the real errno/message server-side for every qr-proxy failure. - Show the server message in the QR poll UI; keep "network error" only for failed local fetches. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
51 lines
2.4 KiB
JavaScript
51 lines
2.4 KiB
JavaScript
import { describe, it } from 'node:test'
|
|
import assert from 'node:assert/strict'
|
|
import { classifyNetworkError, hostOfUrl } from '../lib/utils/net-error.js'
|
|
import { apiError, MESSAGES } from '../lib/i18n.js'
|
|
import { readFileSync } from 'node:fs'
|
|
|
|
const CODES = [
|
|
'upstream_dns', 'upstream_timeout', 'upstream_unreachable', 'upstream_cert', 'upstream_error',
|
|
'upstream_http_status', 'invalid_upstream_response', 'profile_http_status', 'profile_rejected',
|
|
'login_finalize_failed',
|
|
]
|
|
|
|
describe('classifyNetworkError', () => {
|
|
it('maps errno/TLS codes to actionable api codes', () => {
|
|
assert.equal(classifyNetworkError({ code: 'ENOTFOUND' }), 'upstream_dns')
|
|
assert.equal(classifyNetworkError({ code: 'EAI_AGAIN' }), 'upstream_dns')
|
|
assert.equal(classifyNetworkError({ code: 'ETIMEDOUT' }), 'upstream_timeout')
|
|
assert.equal(classifyNetworkError({ message: 'directRequest timeout after 3000ms: x' }), 'upstream_timeout')
|
|
assert.equal(classifyNetworkError({ code: 'ECONNREFUSED' }), 'upstream_unreachable')
|
|
assert.equal(classifyNetworkError({ message: 'socket hang up' }), 'upstream_unreachable')
|
|
assert.equal(classifyNetworkError({ code: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE' }), 'upstream_cert')
|
|
assert.equal(classifyNetworkError({ code: 'SELF_SIGNED_CERT_IN_CHAIN' }), 'upstream_cert')
|
|
assert.equal(classifyNetworkError({ message: 'unable to get local issuer certificate' }), 'upstream_cert')
|
|
assert.equal(classifyNetworkError({ code: 'WHATEVER' }), 'upstream_error')
|
|
assert.equal(classifyNetworkError(null), 'upstream_error')
|
|
})
|
|
|
|
it('extracts host without throwing', () => {
|
|
assert.equal(hostOfUrl('https://icenterapi.zte.com.cn/a/b'), 'icenterapi.zte.com.cn')
|
|
assert.equal(hostOfUrl('not a url'), '')
|
|
})
|
|
})
|
|
|
|
describe('upstream error messages', () => {
|
|
it('are defined in zh and en and interpolate host', () => {
|
|
for (const code of CODES) {
|
|
assert.ok(MESSAGES.zh['err.' + code], 'zh ' + code)
|
|
assert.ok(MESSAGES.en['err.' + code], 'en ' + code)
|
|
}
|
|
const m = apiError('upstream_dns', 'zh', { host: 'uac.zte.com.cn' })
|
|
assert.equal(m.error, 'upstream_dns')
|
|
assert.match(m.message, /uac\.zte\.com\.cn/)
|
|
})
|
|
|
|
it('are mirrored in the browser client dictionary', () => {
|
|
const client = readFileSync(new URL('../lib/client.js', import.meta.url), 'utf8')
|
|
for (const code of CODES) {
|
|
assert.equal(client.split(`"err.${code}":`).length - 1, 2, code)
|
|
}
|
|
})
|
|
})
|