oclaw/tests/test_direct_loop_empty_assistant_response.py

from __future__ import annotations

from types import SimpleNamespace

from svc.persistence.sqlite_store import SqliteStore
from runtime.direct_loop import run_oclaw_direct_loop
from runtime.tools.base import ToolRegistry, ToolSpec


class _Model:
    base_url = ""
    thinking_mode_enabled = False

    def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
        return SimpleNamespace(content="", reasoning_content="", tool_calls=[])


def test_direct_loop_keeps_empty_assistant_without_stub(tmp_path) -> None:  # noqa: ANN001
    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=_Model(),
        tools=ToolRegistry([]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=1,
    )
    assert out.final_text == ""
    rows = store.get_messages(session_id=sess.id, limit=10)
    assistant = [r for r in rows if getattr(r, "role", "") == "assistant"]
    assert not any("空响应" in str(getattr(r, "content", "") or "") for r in assistant)


class _ModelRetryOnce:
    base_url = ""
    thinking_mode_enabled = False

    def __init__(self) -> None:
        self.calls = 0

    def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
        self.calls += 1
        if self.calls == 1:
            return SimpleNamespace(content="", reasoning_content="", tool_calls=[])
        return SimpleNamespace(content="ok-after-retry", reasoning_content="", tool_calls=[])


def test_direct_loop_retries_once_before_stub(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _ModelRetryOnce()
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_MAX", "1")
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=1,
    )
    assert out.final_text == "ok-after-retry"
    assert model.calls == 2
    rows = store.get_messages(session_id=sess.id, limit=10)
    assistant = [r for r in rows if getattr(r, "role", "") == "assistant"]
    assert not any("空响应" in str(getattr(r, "content", "") or "") for r in assistant)
    monkeypatch.delenv("AIA_EMPTY_ASSISTANT_RETRY_MAX", raising=False)
    monkeypatch.delenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", raising=False)


class _ModelDsmlThenText:
    base_url = ""
    thinking_mode_enabled = False

    def __init__(self) -> None:
        self.calls = 0

    def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
        self.calls += 1
        if self.calls == 1:
            return SimpleNamespace(
                content='<||DSML||tool_calls><||DSML||invoke name="run_command"></||DSML||invoke></||DSML||tool_calls>',
                reasoning_content="",
                tool_calls=[],
            )
        return SimpleNamespace(content="native-tools-recovered", reasoning_content="", tool_calls=[])


def test_direct_loop_retries_when_dsml_text_tool_call(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _ModelDsmlThenText()
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_MAX", "1")
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    dummy_tool = ToolSpec(
        name="run_command",
        description="dummy",
        parameters={"type": "object", "properties": {}, "additionalProperties": True},
        handler=lambda args: {"ok": True, "args": args},
        read_only=True,
    )
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([dummy_tool]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=1,
    )
    assert out.final_text == "native-tools-recovered"
    assert model.calls == 2


class _ModelAlwaysDsml:
    base_url = ""
    thinking_mode_enabled = False

    def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
        return SimpleNamespace(
            content=(
                "<||DSML||tool_calls>"
                '<||DSML||invoke name="read_file">'
                "<||DSML||parameter name=\"path\" string=\"true\">"
                "</||DSML||tool_calls>"
            ),
            reasoning_content="",
            tool_calls=[],
        )


def test_direct_loop_dsml_text_persisted_as_failed_tool_pair(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _ModelAlwaysDsml()
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_MAX", "1")
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    dummy_tool = ToolSpec(
        name="read_file",
        description="dummy",
        parameters={"type": "object", "properties": {}, "additionalProperties": True},
        handler=lambda args: {"ok": True, "args": args},
        read_only=True,
    )
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([dummy_tool]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=1,
    )
    assert "DSML" in out.final_text
    rows = store.get_messages(session_id=sess.id, limit=20)
    tool_rows = [r for r in rows if getattr(r, "role", "") == "tool"]
    assert tool_rows
    assert any("model_protocol_mismatch_dsml" in str(getattr(r, "content", "") or "") for r in tool_rows)


class _ModelMixedTextualToolIntent:
    base_url = ""
    thinking_mode_enabled = False

    def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
        return SimpleNamespace(
            content=(
                "输出没抓到。再来：\n\n"
                "<||DSML||tool_calls>\n"
                "<||DSML||invoke name=\"run_command\">\n"
                "<||DSML||parameter name=\"command\" string=\"true\">echo test</||DSML||parameter>\n"
                "</||DSML||invoke>\n"
                "</||DSML||tool_calls>"
            ),
            reasoning_content="",
            tool_calls=[],
        )


def test_direct_loop_mixed_text_dsml_promoted_and_executes(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _ModelMixedTextualToolIntent()
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_MAX", "1")
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    dummy_tool = ToolSpec(
        name="run_command",
        description="dummy",
        parameters={"type": "object", "properties": {}, "additionalProperties": True},
        handler=lambda args: {"ok": True, "args": args},
        read_only=True,
    )
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([dummy_tool]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=1,
    )
    rows = store.get_messages(session_id=sess.id, limit=30)
    tool_rows = [r for r in rows if getattr(r, "role", "") == "tool"]
    assert tool_rows
    assert any('"ok": true' in str(getattr(r, "content", "") or "") for r in tool_rows)
    assert not any("model_protocol_mismatch_dsml" in str(getattr(r, "content", "") or "") for r in tool_rows)
    assert any(str(getattr(r, "event_type", "") or "") == "tool_result" for r in rows)


def test_direct_loop_split_reasoning_dsml_executes_tool_result(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    p = "\uFF5C"
    reasoning = (
        f"<{p}{p}DSML{p}{p}tool_calls>\n"
        f"<{p}{p}DSML{p}{p}invoke name=\"read_file\">\n"
        f"<{p}{p}DSML{p}{p}parameter name=\"path\" string=\"true\">README.md</{p}{p}DSML{p}{p}parameter>\n"
        f"</{p}{p}DSML{p}{p}invoke>\n"
        f"</{p}{p}DSML{p}{p}tool_calls>"
    )

    class _ModelSplitReasoningDsml:
        base_url = "https://api.deepseek.com/v1"
        thinking_mode_enabled = True

        def __init__(self) -> None:
            self.calls = 0

        def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
            self.calls += 1
            if self.calls == 1:
                return SimpleNamespace(
                    content="让我检查一下。",
                    reasoning_content=reasoning,
                    tool_calls=[],
                )
            return SimpleNamespace(content="检查完毕。", reasoning_content="", tool_calls=[])

    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _ModelSplitReasoningDsml()
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    dummy_tool = ToolSpec(
        name="read_file",
        description="dummy",
        parameters={"type": "object", "properties": {}, "additionalProperties": True},
        handler=lambda args: {"ok": True, "path": args.get("path")},
        read_only=True,
    )
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([dummy_tool]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=2,
    )
    assert out.final_text == "检查完毕。"
    rows = store.get_messages(session_id=sess.id, limit=30)
    tool_rows = [r for r in rows if getattr(r, "role", "") == "tool"]
    assert tool_rows
    assert any('"ok": true' in str(getattr(r, "content", "") or "") for r in tool_rows)
    assert str(getattr(rows[-1], "event_type", "") or "") == "assistant_text"


class _ModelDeepseekDsmlThenPlain:
    base_url = "https://api.deepseek.com/v1"
    thinking_mode_enabled = False

    def __init__(self) -> None:
        self.calls = 0

    def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
        self.calls += 1
        if self.calls == 1:
            return SimpleNamespace(
                content=(
                    "<||DSML||tool_calls>\n"
                    "<||DSML||invoke name=\"run_command\">\n"
                    '<||DSML||parameter name="command" string="true">echo dsml</||DSML||parameter>\n'
                    "</||DSML||invoke>\n"
                    "</||DSML||tool_calls>"
                ),
                reasoning_content="",
                tool_calls=[],
            )
        return SimpleNamespace(content="after-tools", reasoning_content="", tool_calls=[])


def test_direct_loop_dsml_text_tools_executed_for_deepseek_base_url(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _ModelDeepseekDsmlThenPlain()
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    dummy_tool = ToolSpec(
        name="run_command",
        description="dummy",
        parameters={"type": "object", "properties": {}, "additionalProperties": True},
        handler=lambda args: {"ok": True, "args": args},
        read_only=True,
    )
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([dummy_tool]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=2,
    )
    assert out.final_text == "after-tools"
    assert model.calls == 2
    rows = store.get_messages(session_id=sess.id, limit=30)
    tool_rows = [r for r in rows if getattr(r, "role", "") == "tool"]
    assert tool_rows
    assert any('"ok": true' in str(getattr(r, "content", "") or "") for r in tool_rows)


def test_direct_loop_dsml_text_tools_env_forces_on(tmp_path, monkeypatch) -> None:  # noqa: ANN001
    """Non-DeepSeek base URL still parses DSML when ``AIA_DSML_TEXT_TOOLS=1``."""

    class _LocalModel:
        base_url = "http://127.0.0.1:9999/v1"
        thinking_mode_enabled = False

        def __init__(self) -> None:
            self.calls = 0

        def chat(self, msgs, tools, on_token=None):  # noqa: ANN001,ARG002
            self.calls += 1
            if self.calls == 1:
                return SimpleNamespace(
                    content='<||DSML||tool_calls><||DSML||invoke name="run_command"></||DSML||invoke></||DSML||tool_calls>',
                    reasoning_content="",
                    tool_calls=[],
                )
            return SimpleNamespace(content="ok", reasoning_content="", tool_calls=[])

    db = tmp_path / "ops.sqlite"
    store = SqliteStore(str(db))
    sess = store.create_session("t")
    model = _LocalModel()
    monkeypatch.setenv("AIA_DSML_TEXT_TOOLS", "1")
    monkeypatch.setenv("AIA_EMPTY_ASSISTANT_RETRY_DELAY_MS", "0")
    dummy_tool = ToolSpec(
        name="run_command",
        description="dummy",
        parameters={"type": "object", "properties": {}, "additionalProperties": True},
        handler=lambda args: {"ok": True, "args": args},
        read_only=True,
    )
    out = run_oclaw_direct_loop(
        store=store,
        session_id=sess.id,
        lang="zh",
        system_prompt="x",
        model=model,
        tools=ToolRegistry([dummy_tool]),
        user_text="hi",
        persist_user_message=True,
        max_tool_rounds=2,
    )
    assert out.final_text == "ok"
    assert model.calls == 2