mirror of
https://github.com/hansjone/oclaw.git
synced 2026-10-09 04:40:45 +08:00
oliver
d8bc08ee0d
Refuse openpyxl/pandas-to_excel via run_command, auto-write content-only files under tmp/, and limit WhatsApp ops short intents to 8 tool rounds by default. Co-authored-by: Cursor <cursoragent@cursor.com>
41 lines
1.7 KiB
Python
41 lines
1.7 KiB
Python
from __future__ import annotations
|
|
|
|
from runtime.tools.public.run_command_tool import run_command_tool
|
|
from runtime.tools.tool_validation import filter_arguments_to_schema, validate_tool_arguments
|
|
|
|
|
|
def test_run_command_accepts_cmd_alias(monkeypatch) -> None:
|
|
calls: list[dict] = []
|
|
|
|
class _Adapter:
|
|
def run_command(self, *, command: str, cwd=None, timeout: int = 300):
|
|
calls.append({"command": command, "cwd": cwd, "timeout": timeout})
|
|
return {"ok": True, "stdout": "hi", "stderr": "", "exit_code": 0}
|
|
|
|
monkeypatch.setattr(
|
|
"runtime.tools.public.run_command_tool.get_local_adapter",
|
|
lambda: _Adapter(),
|
|
)
|
|
spec = run_command_tool()
|
|
args = {"cmd": "echo hi", "timeout": 10}
|
|
filtered = filter_arguments_to_schema(spec.parameters, args)
|
|
ok, err = validate_tool_arguments(spec.parameters, filtered)
|
|
assert ok, err
|
|
out = spec.handler(filtered)
|
|
assert out.get("ok") is True
|
|
assert calls[0]["command"] == "echo hi"
|
|
|
|
|
|
def test_run_command_blocks_openpyxl_xlsx() -> None:
|
|
from runtime.tools.public.run_command_tool import _looks_like_xlsx_via_shell
|
|
|
|
assert _looks_like_xlsx_via_shell("python -c \"import openpyxl; wb=openpyxl.Workbook()\"")
|
|
assert _looks_like_xlsx_via_shell("python -c \"df.to_excel('a.xlsx')\"")
|
|
assert not _looks_like_xlsx_via_shell("echo hello")
|
|
|
|
spec = run_command_tool()
|
|
out = spec.handler({"command": "python -c \"import openpyxl; openpyxl.Workbook()\""})
|
|
assert out.get("ok") is False
|
|
assert out.get("error_code") == "xlsx_via_shell_forbidden"
|
|
assert out.get("retry_forbidden") is True
|
|
assert "write_xlsx" in (out.get("fallback_tools") or [])
|