oclaw/tests/test_workspace_path_guard.py

from __future__ import annotations

import hashlib
import os
import tempfile
import unittest
from pathlib import Path
from unittest import mock

from fastapi.testclient import TestClient

from oclaw.interfaces.http.fastapi_app import create_app
from oclaw.platform.config.paths import db_path
from oclaw.platform.persistence.sqlite_store import SqliteStore
from oclaw.runtime.tools.public.glob_tool import glob_tool
from oclaw.runtime.tools.public.write_file_tool import write_file_tool
from oclaw.runtime.tools.path_guard import (
    access_from_env,
    build_workspace_path_access,
    clear_workspace_path_access_for_tests,
    current_workspace_write_namespace,
    resolve_workspace_path,
    workspace_path_access_scope,
    workspace_write_namespace_scope,
)


class WorkspacePathGuardTests(unittest.TestCase):
    def setUp(self) -> None:
        self._tmp = tempfile.TemporaryDirectory(ignore_cleanup_errors=True)
        self.root = Path(self._tmp.name) / "ws"
        self.root.mkdir(parents=True)
        self.extra = Path(self._tmp.name) / "outside"
        self.extra.mkdir(parents=True)
        clear_workspace_path_access_for_tests()

    def tearDown(self) -> None:
        clear_workspace_path_access_for_tests()
        self._tmp.cleanup()

    def test_default_only_under_workspace_root(self) -> None:
        inner = self.root / "a" / "b.txt"
        inner.parent.mkdir(parents=True)
        inner.write_text("x", encoding="utf-8")
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            with workspace_path_access_scope(None, None):
                p = resolve_workspace_path("a/b.txt")
                self.assertEqual(p, inner.resolve())
                with self.assertRaises(ValueError):
                    resolve_workspace_path(str(self.extra))

    def test_extra_roots_from_env(self) -> None:
        f = self.extra / "f.txt"
        f.write_text("y", encoding="utf-8")
        with mock.patch.dict(
            os.environ,
            {
                "OPS_WORKSPACE_ROOT": str(self.root),
                "OPS_WORKSPACE_EXTRA_ROOTS": str(self.extra),
                "OPS_WORKSPACE_ALLOW_ANY_PATH": "",
            },
            clear=False,
        ):
            with workspace_path_access_scope(None, None):
                p = resolve_workspace_path(str(f))
                self.assertEqual(p, f.resolve())

    def test_glob_tool_accepts_root_parameter(self) -> None:
        sub = self.root / "sub"
        sub.mkdir(parents=True)
        (sub / "a.txt").write_text("a", encoding="utf-8")
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            clear_workspace_path_access_for_tests()
            spec = glob_tool()
            with workspace_path_access_scope(None, None):
                r = spec.handler({"root": str(sub), "pattern": "**/*", "max_results": 50})
            self.assertTrue(r.get("ok"), r)
            self.assertEqual(str(sub.resolve()), str(r.get("root")))
            files = r.get("files") or []
            self.assertTrue(any("a.txt" in f for f in files))

    def test_allow_any_path_from_env(self) -> None:
        f = self.extra / "z.txt"
        f.write_text("z", encoding="utf-8")
        with mock.patch.dict(
            os.environ,
            {
                "OPS_WORKSPACE_ROOT": str(self.root),
                "OPS_WORKSPACE_EXTRA_ROOTS": "",
                "OPS_WORKSPACE_ALLOW_ANY_PATH": "1",
            },
            clear=False,
        ):
            with workspace_path_access_scope(None, None):
                p = resolve_workspace_path(str(f))
                self.assertEqual(p, f.resolve())

    def test_write_file_relative_path_defaults_to_data_workspace_subdir(self) -> None:
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            clear_workspace_path_access_for_tests()
            spec = write_file_tool()
            with workspace_path_access_scope(None, None):
                r = spec.handler({"path": "generated.py", "content": "print('ok')\n", "mode": "overwrite"})
            self.assertTrue(r.get("ok"), r)
            expected = (self.root / "data" / "workspace" / "generated.py").resolve()
            self.assertEqual(str(expected), str(r.get("path")))
            self.assertTrue(expected.exists())

    def test_write_file_relative_path_uses_workspace_namespace_scope(self) -> None:
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            clear_workspace_path_access_for_tests()
            spec = write_file_tool()
            with workspace_path_access_scope(None, None), workspace_write_namespace_scope("ops"):
                self.assertEqual(current_workspace_write_namespace(), "ops")
                r = spec.handler({"path": "generated.py", "content": "print('ok')\n", "mode": "overwrite"})
            self.assertTrue(r.get("ok"), r)
            expected = (self.root / "data" / "workspace" / "generated.py").resolve()
            self.assertEqual(str(expected), str(r.get("path")))
            self.assertTrue(expected.exists())

    def test_write_file_absolute_path_is_kept_when_within_workspace(self) -> None:
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            clear_workspace_path_access_for_tests()
            spec = write_file_tool()
            abs_target = str((self.root / "count_items.py").resolve())
            with workspace_path_access_scope(None, None), workspace_write_namespace_scope("ops"):
                r = spec.handler({"path": abs_target, "content": "print('ok')\n", "mode": "overwrite"})
            self.assertTrue(r.get("ok"), r)
            expected = (self.root / "count_items.py").resolve()
            self.assertEqual(str(expected), str(r.get("path")))
            self.assertTrue(expected.exists())

    def test_per_user_extra_roots_from_db(self) -> None:
        f = self.extra / "u.txt"
        f.write_text("u", encoding="utf-8")
        dbf = Path(self._tmp.name) / "ops.sqlite"
        store = SqliteStore(str(dbf))
        t = store.create_tenant("T")
        tid = str(t["id"])
        u = store.create_user_account(
            tenant_id=tid,
            username="u1",
            display_name="U1",
            role="member",
            password_hash=hashlib.sha256(b"x").hexdigest(),
            is_active=True,
        )
        uid = str(u["id"])
        sess = store.create_session("s")
        sid = str(sess.id)
        store.ensure_ui_session_owner(session_id=sid, tenant_id=tid, user_id=uid)
        store.upsert_user_workspace_path_allowlist(
            tenant_id=tid,
            user_id=uid,
            extra_roots=str(self.extra),
            allow_any_path=False,
        )
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            acc = build_workspace_path_access(store, sid)
            self.assertIn(self.extra.resolve(), [p.resolve() for p in acc.extra_roots])
            with workspace_path_access_scope(store, sid):
                p = resolve_workspace_path(str(f))
                self.assertEqual(p, f.resolve())

    def test_extra_roots_use_ui_owner_fallback_when_tool_session_is_unowned(self) -> None:
        """Specialist steps use a temp chat_session without ui_session_owner; allowlist must follow user session."""
        f = self.extra / "orphan.txt"
        f.write_text("x", encoding="utf-8")
        dbf = Path(self._tmp.name) / "ops2.sqlite"
        store = SqliteStore(str(dbf))
        t = store.create_tenant("T2")
        tid = str(t["id"])
        u = store.create_user_account(
            tenant_id=tid,
            username="u2",
            display_name="U2",
            role="member",
            password_hash=hashlib.sha256(b"z").hexdigest(),
            is_active=True,
        )
        uid = str(u["id"])
        user_sess = store.create_session_for_user(title="ui", tenant_id=tid, user_id=uid)
        user_sid = str(user_sess.id)
        temp_sess = store.create_session("specialist:generalist")
        temp_sid = str(temp_sess.id)
        store.upsert_user_workspace_path_allowlist(
            tenant_id=tid,
            user_id=uid,
            extra_roots=str(self.extra),
            allow_any_path=False,
        )
        with mock.patch.dict(
            os.environ,
            {"OPS_WORKSPACE_ROOT": str(self.root), "OPS_WORKSPACE_EXTRA_ROOTS": "", "OPS_WORKSPACE_ALLOW_ANY_PATH": ""},
            clear=False,
        ):
            acc = build_workspace_path_access(store, temp_sid)
            roots_no_fb = [p.resolve() for p in acc.extra_roots]
            self.assertNotIn(self.extra.resolve(), roots_no_fb)
            acc2 = build_workspace_path_access(store, temp_sid, owner_fallback_session_id=user_sid)
            self.assertIn(self.extra.resolve(), [p.resolve() for p in acc2.extra_roots])
            with workspace_path_access_scope(store, temp_sid, owner_fallback_session_id=user_sid):
                p = resolve_workspace_path(str(f))
                self.assertEqual(p, f.resolve())


class WorkspacePathPolicyAdminApiTests(unittest.TestCase):
    def setUp(self) -> None:
        self._tmp = tempfile.TemporaryDirectory(ignore_cleanup_errors=True)
        self.db = Path(self._tmp.name) / "ops.sqlite"
        os.environ["OPS_ASSISTANT_DB_PATH"] = str(self.db)
        os.environ["OPS_ASSISTANT_PASSWORD"] = "test-admin-pass"
        store = SqliteStore(str(self.db))
        t = store.create_tenant("Team")
        self.tenant_id = str(t["id"])
        store.create_user_account(
            tenant_id=self.tenant_id,
            username="administrator",
            display_name="Admin",
            role="owner",
            password_hash=hashlib.sha256("test-admin-pass".encode("utf-8")).hexdigest(),
            is_active=True,
        )
        self.target = store.create_user_account(
            tenant_id=self.tenant_id,
            username="member1",
            display_name="M1",
            role="member",
            password_hash=hashlib.sha256(b"y").hexdigest(),
            is_active=True,
        )
        self.client = TestClient(create_app())
        self.client.post("/admin/api/auth/bootstrap", json={})
        self.token = self._login()

    def tearDown(self) -> None:
        self._tmp.cleanup()

    def _headers(self) -> dict[str, str]:
        return {"authorization": f"Bearer {self.token}"}

    def _login(self) -> str:
        resp = self.client.post(
            "/admin/api/auth/login",
            json={
                "tenant_id": self.tenant_id,
                "username": "administrator",
                "password": "test-admin-pass",
                "purpose": "console",
            },
        )
        data = resp.json()
        self.assertTrue(data.get("ok"), data)
        return str(data.get("token") or "")

    def test_get_post_workspace_path_policy(self) -> None:
        uid = str(self.target.get("id") or "")
        g = self.client.get(
            f"/admin/api/users/workspace-path-policy?tenant_id={self.tenant_id}&user_id={uid}",
            headers=self._headers(),
        )
        self.assertEqual(g.status_code, 200)
        self.assertTrue(g.json().get("ok"))
        self.assertFalse(g.json().get("from_db"))

        p = Path(self._tmp.name) / "allowed_side"
        p.mkdir(parents=True)
        resp = self.client.post(
            "/admin/api/users/workspace-path-policy",
            json={
                "tenant_id": self.tenant_id,
                "user_id": uid,
                "extra_roots": str(p),
                "allow_any_path": False,
            },
            headers=self._headers(),
        )
        self.assertEqual(resp.status_code, 200)
        self.assertTrue(resp.json().get("ok"), resp.json())
        g2 = self.client.get(
            f"/admin/api/users/workspace-path-policy?tenant_id={self.tenant_id}&user_id={uid}",
            headers=self._headers(),
        )
        data = g2.json()
        self.assertTrue(data.get("from_db"))
        self.assertIn(str(p.resolve()), str((data.get("policy") or {}).get("extra_roots") or ""))

    def test_member_workspace_path_policy_self_only(self) -> None:
        store = SqliteStore(str(self.db))
        mem = store.create_user_account(
            tenant_id=self.tenant_id,
            username="pathmember",
            display_name="Path Member",
            role="member",
            password_hash=hashlib.sha256(b"mem-pass").hexdigest(),
            is_active=True,
        )
        mid = str(mem.get("id") or "")
        resp = self.client.post(
            "/admin/api/auth/login",
            json={
                "tenant_id": self.tenant_id,
                "username": "pathmember",
                "password": "mem-pass",
                "purpose": "console",
            },
        )
        self.assertEqual(resp.status_code, 200)
        tok = str(resp.json().get("token") or "")
        self.assertTrue(tok)
        h = {"authorization": f"Bearer {tok}"}
        g = self.client.get(
            f"/admin/api/users/workspace-path-policy?tenant_id={self.tenant_id}&user_id={mid}",
            headers=h,
        )
        self.assertEqual(g.status_code, 200)
        self.assertTrue(g.json().get("ok"))
        g2 = self.client.get(
            f"/admin/api/users/workspace-path-policy?tenant_id={self.tenant_id}&user_id=wrong-user-id",
            headers=h,
        )
        self.assertEqual(g2.status_code, 403)


if __name__ == "__main__":
    unittest.main()