mirror of
https://github.com/hansjone/netx.git
synced 2026-10-12 10:30:49 +08:00
Drop HTTP polling noise from operation audit by default.
Persist only business events and mutating/failed HTTP calls, and default the audit UI to a business view with an explicit HTTP filter. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
parent
8915455b52
commit
c181158209
8 changed files with 196 additions and 24 deletions
57
tests/test_audit_noise.py
Normal file
57
tests/test_audit_noise.py
Normal file
|
|
@ -0,0 +1,57 @@
|
|||
"""Tests for audit noise filtering (persist policy + list exclude_noise)."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import unittest
|
||||
|
||||
from netx_api.audit_async import audit_should_persist
|
||||
|
||||
|
||||
class AuditShouldPersistTests(unittest.TestCase):
|
||||
def test_drop_successful_http_get(self) -> None:
|
||||
self.assertFalse(
|
||||
audit_should_persist(action="http.get", method="GET", status_code=200, path="/v1/topology")
|
||||
)
|
||||
|
||||
def test_keep_failed_http_get(self) -> None:
|
||||
self.assertTrue(
|
||||
audit_should_persist(action="http.get", method="GET", status_code=500, path="/v1/topology")
|
||||
)
|
||||
|
||||
def test_keep_http_mutations_without_sampling(self) -> None:
|
||||
for method, action in (
|
||||
("POST", "http.post"),
|
||||
("PUT", "http.put"),
|
||||
("PATCH", "http.patch"),
|
||||
("DELETE", "http.delete"),
|
||||
):
|
||||
self.assertTrue(
|
||||
audit_should_persist(action=action, method=method, status_code=200, path="/v1/x"),
|
||||
msg=action,
|
||||
)
|
||||
|
||||
def test_drop_middleware_noise(self) -> None:
|
||||
for action in ("audit.list", "webcrt.get", "webcrt.post", "users.get", "api_tokens.get"):
|
||||
self.assertFalse(
|
||||
audit_should_persist(action=action, method="GET", status_code=200),
|
||||
msg=action,
|
||||
)
|
||||
|
||||
def test_keep_semantic_webcrt(self) -> None:
|
||||
self.assertTrue(audit_should_persist(action="webcrt.session_created", status_code=0))
|
||||
self.assertTrue(audit_should_persist(action="webcrt.command", status_code=0))
|
||||
self.assertTrue(audit_should_persist(action="webcrt.session_closed", status_code=0))
|
||||
|
||||
def test_keep_business_prefixes(self) -> None:
|
||||
self.assertTrue(audit_should_persist(action="auth.login", status_code=200))
|
||||
self.assertTrue(audit_should_persist(action="ne.exec", status_code=200))
|
||||
self.assertTrue(audit_should_persist(action="port_traffic.device.start", status_code=200))
|
||||
self.assertTrue(audit_should_persist(action="config_sync.start", status_code=200))
|
||||
self.assertTrue(audit_should_persist(action="users.create", status_code=200))
|
||||
|
||||
def test_drop_ume_token_get(self) -> None:
|
||||
self.assertFalse(audit_should_persist(action="ume.token.get", method="GET", status_code=200))
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Loading…
Add table
Add a link
Reference in a new issue